-
-
Notifications
You must be signed in to change notification settings - Fork 43
updater: use qubes-vm-update to update dom0 non-interactively #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 92.99% 93.04% +0.04%
==========================================
Files 64 64
Lines 13034 12894 -140
==========================================
- Hits 12121 11997 -124
+ Misses 913 897 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for vm in qapp.domains: | ||
if vm.klass == "AdminVM": | ||
try: | ||
if settings.hide_skipped and bool( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be confused here, but I think the check for skip-update is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in lines 123–126 (dom0 is now treated like the other VMs).
This has conflicts now... |
634aaed
to
6c2c9dd
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025070723-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests50 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 12 fixed
Unstable testsPerformance TestsPerformance degradation:7 performance degradations
Remaining performance tests:65 tests
|
opening updater from the widget failed with:
I'm not sure if it's related to this PR, I'll restart the test.. |
GUI updater shows dom0 update progress
requires: QubesOS/qubes-core-admin-linux/pull/191