fix: add missing language_id to user fixtures and placeholders #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yammesicka
approved these changes
Feb 8, 2021
OdeYec
reviewed
Feb 8, 2021
| password="p", | ||
| email="e@mail.com", | ||
| language="", | ||
| lanauge_id=1, |
Collaborator
There was a problem hiding this comment.
There is an error here - lanauge_id > language_id. @yammesicka shouldn't this have failed the checker?
Contributor
Author
There was a problem hiding this comment.
@OdeChan, it seems it didn't fail as (I think) the placeholder code there isn't run in a test, as one line before it gets the User object from user = session.query(User).filter_by(id=1).first(), which seems to be added to the database by the test before it reaches it. Anyways, thanks for catching it, sent a PR to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.