Skip to content

Commit 4df85bc

Browse files
authored
fix: add missing language_id to user fixture and placeholders (#239)
1 parent 4faa09a commit 4df85bc

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

app/routers/event.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,11 @@ async def create_new_event(request: Request, session=Depends(get_db)):
4040
end = datetime.strptime(data['end_date'] + ' ' + data['end_time'],
4141
'%Y-%m-%d %H:%M')
4242
user = session.query(User).filter_by(id=1).first()
43-
user = user if user else create_user(username="u", password="p",
44-
email="e@mail.com", language="",
43+
user = user if user else create_user(username="u",
44+
password="p",
45+
email="e@mail.com",
46+
language="",
47+
lanauge_id=1,
4548
session=session)
4649
owner_id = user.id
4750
location_type = data['location_type']

app/routers/user.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,16 @@ def create_user(username: str,
1111
password: str,
1212
email: str,
1313
language: str,
14+
language_id: int,
1415
session: Session) -> User:
1516
"""Creates and saves a new user."""
1617

1718
user = User(
1819
username=username,
1920
password=password,
2021
email=email,
21-
language=language
22+
language=language,
23+
language_id=language_id
2224
)
2325
save(user, session=session)
2426
return user

tests/test_email.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ def bad_user(session: Session) -> User:
226226
username='test_username',
227227
password='test_password',
228228
email='test.email#gmail.com',
229+
language_id=1,
229230
)
230231
yield test_user
231232
delete_instance(session, test_user)

tests/test_search.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ class TestSearch:
4444

4545
@staticmethod
4646
def create_user(session):
47-
user = User(username='testuser', email='test@abc.com', password='1234')
47+
user = User(username='testuser',
48+
email='test@abc.com',
49+
password='1234',
50+
language_id=1)
4851
session.add(user)
4952
session.commit()
5053
return user

tests/test_user.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ def test_create_user(self, session):
99
username='new_test_username',
1010
password='new_test_password',
1111
email='new_test.email@gmail.com',
12-
language='english'
12+
language='english',
13+
language_id=1
1314
)
1415
assert user.username == 'new_test_username'
1516
assert user.password == 'new_test_password'

tests/user_fixture.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ def user(session: Session) -> User:
1212
username='test_username',
1313
password='test_password',
1414
email='test.email@gmail.com',
15-
language='english'
15+
language='english',
16+
language_id=1
1617
)
1718
yield test_user
1819
delete_instance(session, test_user)
@@ -25,7 +26,8 @@ def sender(session: Session) -> User:
2526
username='sender_username',
2627
password='sender_password',
2728
email='sender.email@gmail.com',
28-
language='english'
29+
language='english',
30+
language_id=1
2931
)
3032
yield sender
3133
delete_instance(session, sender)

0 commit comments

Comments
 (0)