Skip to content

Add overloads to load_extension(s) #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2022
Merged

Add overloads to load_extension(s) #1522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
248b4b2
Add overloads to load_extension(s)
Dorukyum Jul 25, 2022
b087f83
Merge branch 'master' into load_ext-overloads
Lulalaby Jul 25, 2022
8e65247
Merge branch 'master' into load_ext-overloads
Lulalaby Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions discord/cog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
Type,
TypeVar,
Union,
overload,
)

import discord.utils
Expand Down Expand Up @@ -757,13 +758,29 @@ def _resolve_name(self, name: str, package: Optional[str]) -> str:
except ImportError:
raise errors.ExtensionNotFound(name)

@overload
def load_extension(
self,
name: str,
*,
package: Optional[str] = None,
recursive: bool = False,
) -> List[str]:
...

@overload
def load_extension(
self,
name: str,
*,
package: Optional[str] = None,
recursive: bool = False,
store: bool = False,
) -> Optional[Union[Dict[str, Union[Exception, bool]], List[str]]]:
...

def load_extension(
self, name, *, package = None, recursive = False, store = False
) -> Optional[Union[Dict[str, Union[Exception, bool]], List[str]]]:
"""Loads an extension.

Expand Down Expand Up @@ -873,12 +890,27 @@ def load_extension(
else:
return final_out

@overload
def load_extensions(
self,
*names: str,
package: Optional[str] = None,
recursive: bool = False,
) -> List[str]:
...

@overload
def load_extensions(
self,
*names: str,
package: Optional[str] = None,
recursive: bool = False,
store: bool = False,
) -> Optional[Union[Dict[str, Union[Exception, bool]], List[str]]]:
...

def load_extensions(
self, *names, package = None, recursive = False, store = False
) -> Optional[Union[Dict[str, Union[Exception, bool]], List[str]]]:
"""Loads multiple extensions at once.

Expand Down