Skip to content

Conversation

@Dorukyum
Copy link
Member

Summary

Adds overload typehints to load_extension and load_extensions to make it easier for users to understand that leaving the store parameter will result in a list.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Jul 25, 2022
@Dorukyum Dorukyum self-assigned this Jul 25, 2022
@ChickenDevs ChickenDevs merged commit c98060f into master Aug 7, 2022
@BobDotCom BobDotCom deleted the load_ext-overloads branch October 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low Low Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants