Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues in options.py #1473

Merged
merged 16 commits into from
Jul 13, 2022
Merged

Fix type issues in options.py #1473

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e21f08d
Update min/max types for better type checking
Dorukyum Jul 6, 2022
620627d
Create InputType type
Dorukyum Jul 6, 2022
b3bccda
Revert commit added by mistake
Dorukyum Jul 6, 2022
2545350
Add missing annotations import
Dorukyum Jul 6, 2022
786c99d
Merge branch 'master' into inputtype-type
Dorukyum Jul 7, 2022
95b7b03
Remove ThreadOption from InputType
Dorukyum Jul 7, 2022
68204d0
Fix all type issues in options.py
Dorukyum Jul 7, 2022
491092f
Add missing import
Dorukyum Jul 8, 2022
7cb55cf
Document input type
Dorukyum Jul 8, 2022
76906cb
Merge branch 'master' into inputtype-type
Lulalaby Jul 8, 2022
8994e13
Merge branch 'master' into inputtype-type
Lulalaby Jul 10, 2022
8a588f7
Merge branch 'master' into inputtype-type
Lulalaby Jul 12, 2022
6dc8a9b
Update discord/commands/options.py
Lulalaby Jul 12, 2022
8d2518c
Merge branch 'master' into inputtype-type
Lulalaby Jul 12, 2022
bb5321e
Revert "Update discord/commands/options.py"
Lulalaby Jul 12, 2022
ced1600
Update discord/commands/options.py
Lulalaby Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert commit added by mistake 
This reverts commit e21f08d.
  • Loading branch information
@Dorukyum
Dorukyum committed Jul 6, 2022
commit b3bccda0c652734e3e9e14e8ad4ee67c05c1cf13
7 changes: 2 additions & 5 deletions discord/commands/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,20 +221,17 @@ def __init__(self, input_type: InputType = str, /, description: Optional[str] =

if self.input_type == SlashCommandOptionType.integer:
minmax_types = (int, type(None))
minmax_typehint = Optional[int]
elif self.input_type == SlashCommandOptionType.number:
minmax_types = (int, float, type(None))
minmax_typehint = Optional[Union[int, float]]
else:
minmax_types = (type(None),)
minmax_typehint = type(None)
minmax_typehint = Optional[Union[minmax_types]] # type: ignore

if self.input_type == SlashCommandOptionType.string:
minmax_length_types = (int, type(None))
minmax_length_typehint = Optional[int]
else:
minmax_length_types = (type(None),)
minmax_length_typehint = type(None)
minmax_length_typehint = Optional[Union[minmax_length_types]] # type: ignore

self.min_value: minmax_typehint = kwargs.pop("min_value", None)
self.max_value: minmax_typehint = kwargs.pop("max_value", None)
Expand Down