-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type issues in options.py #1473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
reviewed
Jul 6, 2022
EmmmaTech
reviewed
Jul 6, 2022
EmmmaTech
reviewed
Jul 6, 2022
So I decided to expand the PR just a little bit and fix every single type issue in this file (there were like 46 after |
Dorukyum
added
priority: high
High Priority
status: awaiting review
Awaiting review from a maintainer
Merge with squash
documentation needed
labels
Jul 7, 2022
Tested and added to documentation. |
Lulalaby
previously approved these changes
Jul 8, 2022
8 tasks
plun1331
previously approved these changes
Jul 11, 2022
Middledot
reviewed
Jul 12, 2022
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Lulalaby
previously approved these changes
Jul 12, 2022
This reverts commit 6dc8a9b.
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Middledot
approved these changes
Jul 12, 2022
Lulalaby
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation needed
priority: high
High Priority
status: awaiting review
Awaiting review from a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates a new type for allowed input types and updates option type parsing to remove all type issues.
The option type should be added to the documentation and we should make sure it's not missing any type.
Also the parsing should be tested for all cases.DoneInformation
Checklist
type: ignore
comments were used, a comment is also left explaining why.