Manually merge update-royin branch with dev branch to add O-ANG rule #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consonant replacing
Fix misspellings in dictionary (words_th.txt)
Tokenize repeating dots and commas from numbers (fix PyThaiNLP#461)
Refactor Royin Transliterate: Avoid embedded if blocks and simplified consonant replacing operations
Fix misspellings in dictionary (words_th.txt)
|
Hello @veer66! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-06-03 08:57:07 UTC |
bact
reviewed
Jun 3, 2021
Member
bact
left a comment
bact
left a comment
There was a problem hiding this comment.
One test failed.
FAIL: test_romanize_royin_basic (tests.test_transliterate.TestTransliteratePackage)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\projects\pythainlp-9y1ch\tests\test_transliterate.py", line 63, in test_romanize_royin_basic
self.assertEqual(romanize(word, engine="royin"), expect)
AssertionError: 'hyak' != 'yak'
- hyak
? -
+ yak
Author
It is fixed by the latest commit. |
Member
|
The test that failed is from unrelated ConceptNet part, which we will investigate separately from this PR. I think we are good to merge this for now. |
bact
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
The O-ANG rule was convert into dev branch style.
What was wrong
update-royin and dev are conflicted.
How this fixes it
Write the rule in dev branch style
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.