Skip to content

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Apr 26, 2021

What does this changes

  • Add 'อ' rule

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@wannaphong wannaphong changed the title Update royin.py [WIP] Update royin.py Apr 26, 2021
@coveralls
Copy link

coveralls commented May 4, 2021

Coverage Status

Coverage increased (+0.003%) to 95.797% when pulling f6314da on update-royin into 68c3e81 on dev.

@bact bact added the bug bugs in the library label May 16, 2021
@wannaphong wannaphong changed the title [WIP] Update royin.py Add 'อ' rule to royin.py May 19, 2021
@wannaphong wannaphong requested a review from bact May 19, 2021 04:20
@bact
Copy link
Member

bact commented May 22, 2021

After refactoring in #566, the rule of a syllable starts with "อ" may need to adjust.

@veer66
Copy link

veer66 commented May 29, 2021

@bact I don't know whether I commit to the right place. #568 🤦‍

@wannaphong wannaphong closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bugs in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants