Skip to content

Change Translate to class #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wannaphong merged 8 commits into from
Dec 30, 2020
Merged

Change Translate to class #508

wannaphong merged 8 commits into from
Dec 30, 2020

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Dec 29, 2020

from #439 , I change pythainlp.translate.translate function to pythainlp.translate.Translate class and I update docs.

@pep8speaks
Copy link

pep8speaks commented Dec 29, 2020 •
edited
Loading

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-30 07:27:18 UTC

@wannaphong wannaphong requested a review from bact December 29, 2020 06:36
@wannaphong
Copy link
Member Author

wannaphong commented Dec 29, 2020

Google colab for test https://colab.research.google.com/drive/1tTNIj996ySPdTPuKoXo976Gd6Du-cDIE?usp=sharing

@coveralls
Copy link

coveralls commented Dec 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 95.845% when pulling ce547a6 on translate-class into 907f2d6 on dev.

@bact
Copy link
Member

bact commented Dec 30, 2020

What about split the class to two classes?
One for EN->TH, another for TH->EN ?
This way, the user will load only the model that they will use to the memory?

Let me try that.

@wannaphong
Copy link
Member Author

wannaphong commented Dec 30, 2020 via email •
edited
Loading

bact
bact approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wannaphong wannaphong merged commit c2e65bc into dev Dec 30, 2020
@bact bact deleted the translate-class branch December 30, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wannaphong @pep8speaks @coveralls @bact