Skip to content

Add pythainlp.translate #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bact merged 80 commits into from
Dec 28, 2020
Merged

Add pythainlp.translate #439

bact merged 80 commits into from
Dec 28, 2020

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 24, 2020

@pep8speaks
Copy link

pep8speaks commented Jun 24, 2020 •
edited
Loading

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-28 20:05:52 UTC

@wannaphong
Copy link
Member Author

wannaphong commented Jun 24, 2020

Colab : https://colab.research.google.com/drive/1bW-ZI4DTGr6azO_I2whX_q3tDc8AYBx2?usp=sharing

@wannaphong wannaphong changed the title Add pythainlp.translate [WIP] Add pythainlp.translate Jun 24, 2020
p16i
p16i reviewed Jun 24, 2020
View reviewed changes
@wannaphong wannaphong modified the milestones: 2.2, 2.3, Future Jun 26, 2020
@coveralls
Copy link

coveralls commented Jun 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 95.83% when pulling 346fabc on add-translate into e2243df on dev.

p16i
p16i reviewed Jun 27, 2020
View reviewed changes
p16i
p16i reviewed Jun 27, 2020
View reviewed changes
@wannaphong
Copy link
Member Author

wannaphong commented Jun 27, 2020

@heytitle Thank you. I updated code.

@wannaphong wannaphong changed the title [WIP] Add pythainlp.translate Add pythainlp.translate Dec 27, 2020
@wannaphong
Copy link
Member Author

wannaphong commented Dec 27, 2020

Now, pythainlp.translate is ready to use and fairseq 0.10.1 released to PyPI. https://colab.research.google.com/drive/1bW-ZI4DTGr6azO_I2whX_q3tDc8AYBx2?usp=sharing

@bact

@bact
Copy link
Member

bact commented Dec 28, 2020

Please check AppVeyor

PermissionError: [WinError 5] Access is denied: 'fairseq\examples'

@wannaphong
Copy link
Member Author

wannaphong commented Dec 28, 2020

Please check AppVeyor

PermissionError: [WinError 5] Access is denied: 'fairseq\examples'

Now, AppVeyor is work.

bact
bact approved these changes Dec 28, 2020
View reviewed changes
@bact bact merged commit d5220d9 into dev Dec 28, 2020
@bact bact deleted the add-translate branch December 28, 2020 20:28
@wannaphong wannaphong mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact approved these changes

@p16i p16i p16i left review comments

Assignees

No one assigned

Labels

enhancement enhance functionalities hacktoberfest-accepted hacktoberfest accepted pull requests.

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

6 participants

@wannaphong @pep8speaks @coveralls @p16i @bact