Conversation
CodSpeed Performance ReportMerging #3680 will not alter performanceComparing Summary
|
davidhewitt
commented
Dec 21, 2023
adamreichold
approved these changes
Dec 21, 2023
Member
adamreichold
left a comment
There was a problem hiding this comment.
Tiny nit w.r.t. documentation, otherwise LGTM.
Member
Author
|
Thanks for all these reviews 🙏 I think my next step today is to write a high-level summary of the tasks remaining before I think we can release this API, so that we all have a sense of progress (and can coordinate picking up items in parallel if desired). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #3606
Follows the same patterns we've seen in #3675 for the gil-ref iterator to wrap the new iterator. I think this is again extremely mechanical.