"full" implementation of new Py2 API#3606
Closed
davidhewitt wants to merge 8 commits intoPyO3:mainfrom
Closed
Conversation
3235ef6 to
d4baf2a
Compare
CodSpeed Performance ReportMerging #3606 will degrade performances by 34.69%Comparing Summary
Benchmarks breakdown
|
bd4fbf3 to
cec5294
Compare
48244c9 to
9ed701d
Compare
This was referenced Dec 14, 2023
Closed
205fb70 to
a852026
Compare
This was referenced Dec 20, 2023
9693e6a to
53e3f00
Compare
This was referenced Dec 26, 2023
9ab55e9 to
0b9dd26
Compare
This was referenced Jan 27, 2024
220ee43 to
3eb1a26
Compare
This was referenced Jan 30, 2024
3eb1a26 to
c7d22cb
Compare
This was referenced Jan 30, 2024
Merged
8ffb364 to
357558f
Compare
dad295a to
c45427e
Compare
c45427e to
c3d9e69
Compare
Member
Author
|
This branch has now outlived its usefulness. We've split out basically everything into other PRs, and I see no further need to keep trying to rebase this here for the few remaining odds and ends, so I'll close this. Great work everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3382
This branch has been used to implement pydantic/pydantic-core#1085
It's based on top of #3572, and also includes #3600 as well as updated forms of most of the other PRs introducing Py2 types.
I feel like this strikes a good balance of introducing the new
Py2API without breaking much of the existing gil refs API. The only thing which really needed to change was theFromPyObjecttrait, to take&Py2<'py, PyAny>instead of&'py PyAny. I don't think I'd want to land this amongst other breaking changes. I do think this might be releasable as an 0.22 release with both APIs still present (maybe gate the GIL refs API with abackcompatfeature), with a view to dropping the gil refs API in 0.24 maybe.Next steps:
We want to release
pydantic-coreagainst a form of this branch in the near future. Any opinions if I should release this as a fork of PyO3, or we release this as an 0.22 alpha?I plan to start splitting this out into reviewable PRs and keep this one rebased as we move forwards.
This also needs further cleanup / documentation etc.