Stop hardcode platform tag when using zig#2905
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes hardcoded platform tag determination when using Zig for cross-compilation on Linux glibc targets. Instead of forcing a specific manylinux version based on Rust compiler capabilities, the build now defers to auditwheel to automatically detect the appropriate compatibility tag based on the actual binary's dependencies and symbols.
- Changed zig+glibc builds to return
Nonefor platform tag instead oftarget.get_minimum_manylinux_tag() - Removed test assertions that validated the hardcoded platform tag behavior
- Removed unused
PlatformTagimport from test file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/build_options.rs | Changed zig+glibc builds to return None for compatibility tag instead of hardcoded minimum manylinux tag, allowing auditwheel to dynamically determine the appropriate tag based on actual binary dependencies |
| tests/common/integration.rs | Removed test logic that validated hardcoded platform tags for zig builds and removed now-unused PlatformTag import |
50e9615 to
3aeae01
Compare
3aeae01 to
eb38efe
Compare
tuxu
added a commit
to tuxu/maturin
that referenced
this pull request
Jan 6, 2026
This reverts commit d637e6e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #2901 (comment)