Update manylinux/musllinux policies to the latest main #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this change broke CI: |
Member
|
I think we should change that test to higher manylinux version, the symbol is only backlisted on manylinux <= 2.17. |
messense
added a commit
that referenced
this pull request
Dec 29, 2025
messense
pushed a commit
that referenced
this pull request
Jan 6, 2026
PR #2901 updated the manylinux policies, which now include `__cxa_thread_atexit_impl`. This symbol is [linked weakly](https://github.com/rust-lang/rust/blob/4fa80a5e733e2202d7ca4c203c2fdfda41cfe7dc/library/std/src/sys/thread_local/destructors/linux_like.rs#L4) by the Rust stdlib. Rather than requiring a bump of the minimum manylinux platform tag for users, ignore weak symbols in the check. This is in line with changes to PyPA's auditwheel (pypa/auditwheel#665).
joseph-isaacs
added a commit
to vortex-data/vortex
that referenced
this pull request
Jan 6, 2026
the PR that was incorrect: PyO3/maturin#2901 However I think we should pin maturin going forward? --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action