Add solhint #54
Open
Add solhint #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forge fmt feat: add WithdrawalManager contract for mainnet deployment feat: update requestWithdrawals to manage withdrawals and batch processing for toBurn and toTransfer arrays feat: restructure WithdrawalManager to use a Withdrawal struct and update requestWithdrawals function to include recipient address feat: update requestWithdrawals to store Withdrawal struct in withdrawals array feat: update BATCH_SIZE to 10 and adjust withdrawal logic accordingly refactor: consolidate withdrawal management by replacing multiple arrays with a single WithdrawalBatch struct array fix: update initial exchange rate to 0 in WithdrawalManager contract feat: add WithdrawalRequested event to requestWithdrawals function fix: restore emit statement for WithdrawalRequested in WithdrawalManager contract feat: add validation to prevent finalizing an already finalized withdrawal batch feat: replace require statement with custom error for batch finalization check wip aider stuff feat: loop over withdrawal batches to finalize them in finalizeWithdrawals function fix: reintroduce validation to prevent finalizing already finalized withdrawal batches feat: add constructor to initialize immutable PufferVaultV3 variable feat: import PufferVaultV3 and update withdrawal logic to use its exchange rate for transfers feat: import OpenZeppelin's Math library and use min function in completeQueuedWithdrawal fix: correct withdrawal logic in WithdrawalManager contract to ensure accurate ETH transfer and burning of pufETH feat: create BatchFinalized event and emit it in finalizeWithdrawals function feat: update withdrawal process to include dynamic exchange rate calculation and improve batch finalization logic fix: resolve undeclared identifiers in WithdrawalManager contract feat: update BatchFinalized event and refactor withdrawal logic in WithdrawalManager contract feat: use custom errors instead of revert in WithdrawalManager contract feat: use SafeTransferLib for secure ETH transfers in WithdrawalManager docs: update comment to clarify batch finalization behavior in WithdrawalManager contract fix: prevent finalizeWithdrawals if the batch is not full by adding a check and reverting with BatchNotFull error refactor: remove outdated comments and clean up code in WithdrawalManager contract fix: update import and usage of SafeTransferLib to Address for ETH transfers in WithdrawalManager.sol feat: introduce minimum withdrawal amount of 0.01 ETH in WithdrawalManager contract feat: replace require statements with custom errors for withdrawal amount validation feat: enhance WithdrawalManager with error handling and event logging for withdrawals feat: add WithdrawalCompleted event and emit it in completeQueuedWithdrawal function add the missing event feat: add unit tests for WithdrawalManager contract test: add test for creating five deposits in WithdrawalManager.t.sol feat: create multiple actors for deposits from different addresses in tests fuzz test: add test for 10 deposits and finalizeWithdrawals function basic withdrawal test update gitignore test POC
* FWR Deployment script (#36) * remove unused imports * update the deployment script * forge fmt * remove unused variables * forge fmt * remove duplicate import --------- Co-authored-by: bxmmm1 <bxmmm1@users.noreply.github.com> * docs: update README.md (#35) reedamable -> redeemable * constructor code coverage (#37) * L2RewardManager bugfix * fmt * Upload signed audit reports (#39) * feat: add ACL, interfaces, upgradability * Create puffer.json * Delete mainnet-contracts/mainnet-contracts/output/puffer.json * chore: adding puffer to the files name * chore: improved natspec with convention * fix: acl in tests ; 4 still failing * fix: acl in tests; still 2 failing * fix: checks and passing tests * feat: add withdraw idx, batch idx in event * feat: add permit in `requestWithdrawals` * update withdrawal manager * update wording * update natspec * update common addresses in test helper * fmt * FWR Fixes (#44) FWR audit fixes * getter test --------- Co-authored-by: Benjamin <benjaminxh+github@gmail.com> Co-authored-by: bxmmm1 <bxmmm1@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Codecov ReportAttention: Patch coverage is
|
…to feature/solhint
ksatyarth2
reviewed
Sep 16, 2024
| @@ -161,7 +161,7 @@ contract L1RewardManager is | |||
| * @notice This contract receives XPufETH from the L2RewardManager via the bridge, unwraps it to pufETH and then burns the pufETH, reverting the original mintAndBridge call | |||
| * @dev Restricted access to `ROLE_ID_BRIDGE` | |||
| */ | |||
| function xReceive(bytes32, uint256, address, address originSender, uint32 originDomainId, bytes memory callData) | |||
| function xReceive(bytes32, uint256, address, address originSender, uint32 originDomainId, bytes calldata callData) | |||
There was a problem hiding this comment.
will these changes memory -> calldata affect future upgradation (if any) by any chance?
ksatyarth2
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.