Minor changes to FWR tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
bxmmm1
added a commit
that referenced
this pull request
Sep 3, 2024
* FWR Deployment script (#36) * remove unused imports * update the deployment script * forge fmt * remove unused variables * forge fmt * remove duplicate import --------- Co-authored-by: bxmmm1 <bxmmm1@users.noreply.github.com> * docs: update README.md (#35) reedamable -> redeemable * constructor code coverage (#37) * L2RewardManager bugfix * fmt * Upload signed audit reports (#39) * feat: add ACL, interfaces, upgradability * Create puffer.json * Delete mainnet-contracts/mainnet-contracts/output/puffer.json * chore: adding puffer to the files name * chore: improved natspec with convention * fix: acl in tests ; 4 still failing * fix: acl in tests; still 2 failing * fix: checks and passing tests * feat: add withdraw idx, batch idx in event * feat: add permit in `requestWithdrawals` * update withdrawal manager * update wording * update natspec * update common addresses in test helper * fmt * FWR Fixes (#44) FWR audit fixes * getter test --------- Co-authored-by: Benjamin <benjaminxh+github@gmail.com> Co-authored-by: bxmmm1 <bxmmm1@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.