-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metadata schema to the code base itself #7409
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
for more information, see https://pre-commit.ci
Should this file exist here or put elsewhere? Currently the schema is stored in |
Yes, just make this draft PR to help review and leave comments. After finished we can move it in |
Can we prepare a test case, like using 1) this schema and 2) prepare a fake metadata.json file to use |
Yes I can put that together shortly. |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
for more information, see https://pre-commit.ci
@yiheng-wang-nv I've added a notebook demonstrating this now. We won't want to merge this into dev, it's just a demo as the schema file is. |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Outstanding discussion points:
|
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
for more information, see https://pre-commit.ci
I've made |
Hi @ericspod @KumoLiu @Nic-Ma , I rechecked this draft PR's changes. I agree to use |
@yiheng-wang-nv I don't have any blockers for this PR. The jupyter notebook and schema file should be removed and the schema file instead uploaded here where the other versions live. |
I see. Thanks for the response. Do you think we should add |
I agree we can directly add |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
I've added |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
My comments are minor and please feel free to skip/close them as needed for merge. Thanks! |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
I've addressed comments and remove the schema file now. |
The schema is now uploaded as meta_schema_20240725.json. |
/build |
Thanks @ericspod for the contribution. I will use the new schema in: https://github.com/Project-MONAI/model-zoo/pull/605 |
Fixes #7303 #6959.
Description
This adds the schema file into the code base (but this maybe should be elsewhere). The changes implement a number of new things:
$defs
section per the JSON schema standardpatternProperties
mechanismpost_processed_outputs
section if they are significantly changed with the post-process transforms defined in scriptsnetwork_data_format
, these must follow the pattern<name>_data_format
required_packages_version
added in addition tooptional_packages_version
#7253 depends on this schema change.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.