Rename optional_packages_version to required_packages_version
#7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KumoLiu <yunl@nvidia.com>
|
Thanks! We should add something to the |
Signed-off-by: KumoLiu <yunl@nvidia.com>
Hi @ericspod, I recognize optional_packages_version as required_packages_version and issue a warning in the latest commit. Could you please help review it again? |
Signed-off-by: KumoLiu <yunl@nvidia.com>
ericspod
reviewed
Nov 28, 2023
ericspod
reviewed
Nov 28, 2023
|
Looks good! We should get some more feedback from others however since this will change things and would necessitate a model zoo update. |
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
Any blocker in this MR? Thanks. |
7 tasks
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
ericspod
added a commit
that referenced
this pull request
Jul 25, 2024
Fixes #7303 #6959. ### Description This adds the schema file into the code base (but this maybe should be elsewhere). The changes implement a number of new things: * Moved definitions into a `$defs` section per the JSON schema standard * Permits multiple input arguments and return results from networks with arbitrary names using the `patternProperties` mechanism * Allows the types of inputs and outputs to be, additional to just tensors, numbers, booleans, or strings * Outputs after post processing can be specified with the `post_processed_outputs` section if they are significantly changed with the post-process transforms defined in scripts * Multiple network IO formats can be specified in addition to `network_data_format`, these must follow the pattern `<name>_data_format` * `required_packages_version` added in addition to `optional_packages_version` #7253 depends on this schema change. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6959.
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.