Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions monai/utils/dist.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,13 @@ def __init__(self, rank: int | None = None, filter_fn: Callable = lambda rank: r
if dist.is_available() and dist.is_initialized():
self.rank: int = rank if rank is not None else dist.get_rank()
else:
warnings.warn(
"The torch.distributed is either unavailable and uninitiated when RankFilter is instantiated. "
"If torch.distributed is used, please ensure that the RankFilter() is called "
"after torch.distributed.init_process_group() in the script."
)
if torch.cuda.is_available() and torch.cuda.device_count() > 1:
warnings.warn(
"The torch.distributed is either unavailable and uninitiated when RankFilter is instantiated.\n"
"If torch.distributed is used, please ensure that the RankFilter() is called\n"
"after torch.distributed.init_process_group() in the script.\n"
)
self.rank = 0

def filter(self, *_args):
return self.filter_fn(self.rank)
26 changes: 25 additions & 1 deletion tests/test_rankfilter_dist.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,35 @@ def test_rankfilter(self):
with open(log_filename) as file:
lines = [line.rstrip() for line in file]
log_message = " ".join(lines)
assert log_message.count("test_warnings") == 1
self.assertEqual(log_message.count("test_warnings"), 1)

def tearDown(self) -> None:
self.log_dir.cleanup()


class SingleRankFilterTest(unittest.TestCase):
def tearDown(self) -> None:
self.log_dir.cleanup()

def setUp(self):
self.log_dir = tempfile.TemporaryDirectory()

def test_rankfilter_single_proc(self):
logger = logging.getLogger(__name__)
log_filename = os.path.join(self.log_dir.name, "records_sp.log")
h1 = logging.FileHandler(filename=log_filename)
h1.setLevel(logging.WARNING)
logger.addHandler(h1)
logger.addFilter(RankFilter())
logger.warning("test_warnings")

with open(log_filename) as file:
lines = [line.rstrip() for line in file]
logger.removeHandler(h1)
h1.close()
log_message = " ".join(lines)
self.assertEqual(log_message.count("test_warnings"), 1)


if __name__ == "__main__":
unittest.main()