Skip to content

6894 update rank filter #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2023
Merged

6894 update rank filter #6895

merged 3 commits into from
Aug 21, 2023

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Aug 21, 2023

Fixes #6894

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update rank filter
0765059 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from mingxin-zheng August 21, 2023 13:23
@wyli
autofix
a99f61b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
mingxin-zheng
mingxin-zheng approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli .

@wyli wyli marked this pull request as ready for review August 21, 2023 13:58
@wyli
Copy link
Contributor Author

wyli commented Aug 21, 2023

/build

@wyli wyli enabled auto-merge (squash) August 21, 2023 14:16
@wyli
Copy link
Contributor Author

wyli commented Aug 21, 2023

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented Aug 21, 2023

/build

@wyli
fixes windows test
71a001e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 6894-rank-filter branch from e423f09 to 71a001e Compare August 21, 2023 18:12
@wyli
Copy link
Contributor Author

wyli commented Aug 21, 2023

/build

@wyli wyli merged commit 2daabf9 into Project-MONAI:dev Aug 21, 2023
@wyli wyli deleted the 6894-rank-filter branch September 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingxin-zheng mingxin-zheng mingxin-zheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RankFilter in a single gpu environment

2 participants

@wyli @mingxin-zheng