Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 tutorial updates #183

Merged
merged 22 commits into from
Mar 27, 2020
Merged

86 tutorial updates #183

merged 22 commits into from
Mar 27, 2020

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 16, 2020 •
edited
Loading

Fixes #86

Description

  • updates notebook tutorials
  • revises the spacing transforms
  • revises the orientation transforms

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@wyli wyli requested a review from Nic-Ma March 16, 2020 23:57
@wyli wyli changed the title WIP 86 tutorial updates 86 tutorial updates Mar 26, 2020
@wyli
Copy link
Contributor Author

wyli commented Mar 26, 2020

could you help review this @Nic-Ma ? mainly revised spacing and orientation, with various unit tests. added a new notebook and checked existing ones.

things couldn't be done in this PR because it is too large already:

  • double-check the notebooks, mainly need more descriptions and inline comments
  • another iteration to make the nifti_saver fully aware of the affine header
  • make the spatial transforms more user-friendly

Nic-Ma
Nic-Ma reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the transforms, will check notebooks later.

monai/transforms/composables.py Show resolved Hide resolved
monai/transforms/composables.py Outdated Show resolved Hide resolved
monai/transforms/transforms.py Outdated Show resolved Hide resolved
Nic-Ma
Nic-Ma reviewed Mar 27, 2020
View reviewed changes
monai/transforms/utils.py Outdated Show resolved Hide resolved
Nic-Ma
Nic-Ma approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me now.
Thanks.

@Nic-Ma Nic-Ma merged commit 8072028 into master Mar 27, 2020
@wyli wyli deleted the 86-tutorial branch May 21, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorials & Get Started Guides for Public Alpha
2 participants
@wyli @Nic-Ma