Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show item label instead of Q-IDs if possible #146

Merged
merged 25 commits into from
Feb 6, 2025
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
bd504c6
Show item label instead of Q-IDs if possible
alistair3149 Jan 23, 2025
d6efcc2
Fix various issues raised by CI
alistair3149 Jan 23, 2025
91b82f0
Add missing argument to constructor function
alistair3149 Jan 23, 2025
579c5fa
Add missing use statement
alistair3149 Jan 23, 2025
e0e4dbf
Fix setLabel language code
alistair3149 Jan 23, 2025
d3699f9
Fix language code not being string
alistair3149 Jan 23, 2025
6dda3b2
Use Wikibase MockRepo for test
alistair3149 Jan 23, 2025
5a4004f
Set test to true for now
alistair3149 Jan 23, 2025
beb1fdd
Merge branch 'master' into feat-item-label
alistair3149 Jan 24, 2025
c22a63f
Fix merge issues
alistair3149 Jan 24, 2025
5eb9761
Add FacetLabelBuilder class and use existing class for label lookup
alistair3149 Jan 24, 2025
c0f6895
Fix some of the lint issues
alistair3149 Jan 24, 2025
44d21f6
Fix incorrect type for getFacetLabel
alistair3149 Jan 24, 2025
5d83069
Refactor getPropertyDataTypeId
alistair3149 Jan 27, 2025
ff17692
Drop public methods from FacetLabelBuilder
alistair3149 Jan 27, 2025
084e1d2
Fix getFacetLabelBuilder scope
alistair3149 Jan 27, 2025
9873326
Fix tests
alistair3149 Jan 27, 2025
178e38d
Fix tests
alistair3149 Jan 27, 2025
f162301
Add test
alistair3149 Jan 27, 2025
d780581
Refactor label handling with new FacetValueFormatter
alistair3149 Jan 30, 2025
54d0287
Fix lint issue
alistair3149 Jan 30, 2025
3de83c0
Merge branch 'master' into feat-item-label
alistair3149 Jan 30, 2025
f3a588b
Remove unused todo
alistair3149 Jan 30, 2025
11c0811
Merge branch 'master' into feat-item-label
alistair3149 Jan 31, 2025
da78e10
Merge branch 'master' into feat-item-label
malberts Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
alistair3149 committed Jan 27, 2025
commit 98733269c80cae939a0efdc7c6612046b95cbcc1
3 changes: 2 additions & 1 deletion tests/phpunit/Presentation/UiBuilderUnitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@ public function testTabsViewModelContainsItemTypeProperty(): void {
private function newUiBuilder(
?Config $config = null,
?SpyTemplateParser $templateSpy = null,
?StubLabelLookup $labelLookup = null,
?QueryStringParser $queryStringParser = null
): UiBuilder {
return new UiBuilder(
$config ?? new Config(),
new SpyFacetHtmlBuilder(),
new FakeItemTypeLabelLookup(),
new StubLabelLookup(),
$labelLookup ?? new StubLabelLookup(),
$templateSpy ?? new SpyTemplateParser(),
$queryStringParser ?? new StubQueryStringParser()
);
Expand Down
Loading