Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show item label instead of Q-IDs if possible #146

Merged
merged 25 commits into from
Feb 6, 2025
Merged

Conversation

alistair3149
Copy link
Collaborator

@alistair3149 alistair3149 commented Jan 23, 2025

For #136

Key changes

  • Try to look up localized label for facet items

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (48caa0e) to head (da78e10).

Files with missing lines Patch % Lines
src/Presentation/FacetValueFormatter.php 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
+ Coverage     72.90%   73.50%   +0.60%     
- Complexity      306      315       +9     
============================================
  Files            41       42       +1     
  Lines           967      989      +22     
============================================
+ Hits            705      727      +22     
  Misses          262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair3149 alistair3149 marked this pull request as ready for review January 27, 2025 21:03
@JeroenDeDauw JeroenDeDauw merged commit 570710a into master Feb 6, 2025
14 checks passed
@JeroenDeDauw JeroenDeDauw deleted the feat-item-label branch February 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants