Repository navigation
Keep thinking animation active until generation ends - #415
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the thinking header animated through tool execution and answer streaming. It now settles to brain + Reasoning only when the whole turn finishes; cancellation or failure also stops the animation. The accordion body remains reasoning-only.
The display selector follows turn outcome instead of reasoning-segment completion. Expanded the real store/reducer regression across reasoning completion, tool boundaries, tool execution, answer streaming and final settlement.
Validation: production build and full local suite passed (6,117 tests); focused lifecycle tests passed again after rebasing onto latest main. A detached probe using the real loaded Obsidian store, bubble and disclosure verified all intermediate states remain active and terminal completion settles. Installed and verified in Professor Synapse. The existing full-suite worker teardown warning remains.
Follow-up to #413.