Repository navigation
Unify thinking disclosure and centralize chat turn state - #413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify the separate thinking ticker and disclosure into one native accordion. While reasoning arrives, the familiar icon pulses and words type letter by letter with cycling dots and a silver sweep. When reasoning ends, the header settles to a static brain icon and Reasoning. Expansion and reading position survive reconciliation and completion; the circular down-arrow resumes following without overriding the transcript’s independent scroll intent. Tool activity stays in the status bar.
The supporting chat refactor gives each generation one service-owned runtime snapshot. Generation outcome and persistence outcome are separate: a completed response stays completed if saving fails, and Retry save retries storage without repeating model or tool work. Targeted message writes replace routine whole-conversation snapshots, reject deleted targets, and preserve accounting. Generation identity scopes callbacks, queue activity and tool status.
Validation
Boundaries
Failed-save recovery is in memory, not crash recovery. Existing JSONL persistence remains authoritative; no schema or dependency changes. This scopes foreground chat ownership, not all Nexus subsystems.
The full suite still reports a worker teardown warning; a focused UI open-handle check passed. An independent duplicate-name error in existing default-workspace initialization was observed in the disposable vault and is documented for follow-up. Physical mobile hardware was not tested.
Implementation details and reproducible test instructions:
docs/plans/thinking-disclosure-implementation-notes.mdandtests/manual/thinking-disclosure-e2e.md.