Limit rendering chunks #3767
Open
Limit rendering chunks #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers even when you send the viewDistance setting to it, they can send the default chunk amount that has been set, so you must check how much chunks you are receiving before saving them in to memory
Member
|
Please undo irrelevant changes and fix lint |
Author
|
be more specific please. |
rom1504
requested changes
Oct 22, 2025
Member
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Undo all of those and many similar unnecessary changes to spaces
| const assert = require('assert') | ||
| const Painting = require('../painting') | ||
| const { onceWithCleanup } = require('../promise_utils') | ||
|
|
| } | ||
|
|
||
| function inject (bot, { version, storageBuilder, hideErrors }) { | ||
| function inject(bot, { version, storageBuilder, hideErrors }) { |
| const paintingsById = {} | ||
|
|
||
| function addPainting (painting) { | ||
| function addPainting(painting) { |
| } | ||
|
|
||
| function deletePainting (painting) { | ||
| function deletePainting(painting) { |
| } | ||
|
|
||
| function delColumn (chunkX, chunkZ) { | ||
| function delColumn(chunkX, chunkZ) { |
| if (dist > viewDist) return | ||
|
|
||
| if (!args.bitMap && args.groundUp) { | ||
| // stop storing the chunk column |
| } | ||
| let column = bot.world.getColumn(args.x, args.z) | ||
| if (!column) { | ||
| // Allocates new chunk object while taking world's custom min/max height into account |
| if (args.biomes !== undefined) { | ||
| column.loadBiomes(args.biomes) | ||
| } | ||
| if (args.biomes !== undefined) column.loadBiomes(args.biomes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers even when you send the viewDistance setting to it, they can send the default chunk amount that has been set, so you must check how much chunks you are receiving before saving them in to memory