Implement skinUsesKeyedProperties for 1.19.3+ #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
player_info packet uses the key field for skin properties instead of name, Applies to Minecraft 1.19.3 and above
Patches an issue if the properties field passed to extractSkinInformation had extra fields it would fail to parse as JSON
[
{
"key": "cmlang",
"value": "val",
"signature": "null"
},
{
"key": "lang_id",
"value": "ru_RU",
"signature": "8492534228807161"
},
{
"key": "textures",
"value": "e3RleHR1cmVzOntTS0lOOnt1cmw6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYjY3MTY4NjIxZmRiMGNmM2Y3ZTU3Y2I1MTY2ZDQ4ZTllOWM4N2Q2Nzc0OTQzMzlmM2I4ZmVlYzhjM2EzNmIifX19",
"signature": "H6Jo2IPL+9oc1RX9EjTwiGx1g36vwKE4s0Oi0/7xwpoy16+NmkF/JvVaGHe1qzef8aTKwa4CtcN0uh8B62xovaPgW/iBqzmVimYS0Z9Ehyzt2atf+rb23VLEHuzbi82gDeM0FP9pG0iqZj8eGzCfSvTp1RGjDiNJv7vB9QiNvzsF3ZLwNRo/1Bc73Wmn//1EkYkwRorecEQhnrsQSlemXP0bW+Q9PByFZfJZyhMXFDtbi+q/DAyPGZUnHqMr1i5sum9xr0un9PduLVR/GR1OMJXplevvGLYVJezWlL1jIYy2pNv3MaCBFW5ZgHP/pzaW4biMBcixWy4a5TE/HctQeOQ8yx4veSKBth193YqqHunqhQP1ZwO+XcdE8l4qibxOY4e2VD2ltc9lt4O9xU4z63YfdcPXHkBQSOhxfkXZF6QX1UhEhPpQiL6X5+pqoAXU85qbFT3g8K3caDwGDiM6ZSP+NyVm5W7RdWD1VPMhpW1klsPQr9PXSH5oIW2gADz7+YnFHzOnm2oFE0EhmWl0sN8RLDJkr+vGItz9r8EHoAFI0anEk5YE9wE7XHkSI90BUmpOXeGtchtuwpkc+WI1ErmwGPbZTsUlVqlv2xIEQ5e6IE9AIyzU3RRssEto/P1xpfRiGkmMxJqNHWG+hSj0Ks6eDzRci51PfczZSs/WjUo="
}
]
|
Can you add a test ? |
|
Stuck on PrismarineJS/minecraft-data#971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player_info packet uses the key field for skin properties instead of name, Applies to Minecraft 1.19.3 and above.
awaiting response to PrismarineJS/minecraft-data#971
Also added a fix on servers that send extra properties which results in a JSON crash