-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployment): add basic Deployment resource #202
Conversation
…aform-provider-prefect into deployment_access
Thanks for the contribution @skyscrapr 🤝 Now that you've opened #201, could you please remove the Flow-related code to keep this PR focused on Deployments? |
Deployments are dependent on flows I split flows into #201. But I'm unsure. How to create this PR if it requires another PR to be merged first. The branch will not pass tests. If you explain how to do this, happy to update the PR and remove flows. I have a third PR for deployment access that I haven't opened since it is depending on deployments and only makes the problem worse. |
…t into resource_deployment
Co-authored-by: Edward Park <ed.sh.park@gmail.com>
Co-authored-by: Edward Park <ed.sh.park@gmail.com>
Thanks for getting this one off the ground @skyscrapr 🤝 |
Summary
Adds Deployment resource with basic fields. More complete support for Deployments will come in future PRs (see #238).
Related to #238
Depends on #201.
Notes
API docs: https://app.prefect.cloud/api/docs#tag/Deployments
This PR is already big, so we're implementing some core fields here and the rest will be implemented in future PR(s)
CI
Acceptance tests
are sometimes failing with503 service unavailable
(and sometimes passing), but I tested the newly-added test by hand and it passed:To do