Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Deployments #238

Open
5 of 7 tasks
mitchnielsen opened this issue Jul 18, 2024 · 2 comments
Open
5 of 7 tasks

Add support for Deployments #238

mitchnielsen opened this issue Jul 18, 2024 · 2 comments
Assignees
@mitchnielsen
Labels
development open-source
Milestone
Parity with the P...

Comments

@mitchnielsen
Copy link
Contributor

mitchnielsen commented Jul 18, 2024 •
edited
Loading

Summary

As a follow-up to support for Flows (#5, #202) let's add support for Deployments.

References

To do
@mitchnielsen mitchnielsen added the enhancement New feature or request label Jul 18, 2024
This was referenced Jul 18, 2024
Closed
Merged
@mitchnielsen mitchnielsen self-assigned this Jul 31, 2024
mitchnielsen added a commit that referenced this issue Aug 15, 2024
@skyscrapr @parkedwards
@mitchnielsen @github-actions
feat(deployment): add basic Deployment resource (#202)
b44a018 
Adds Deployment resource with basic fields. More complete support for Deployments will come in future PRs (see #238).

Related to #238

---------

Co-authored-by: Edward Park <ed.sh.park@gmail.com>
Co-authored-by: Mitchell Nielsen <inbox@mitchn.me>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitchnielsen added a commit that referenced this issue Aug 20, 2024
@mitchnielsen
feat(Deployments): support Parameters
c8df00a 
Supports setting Parameters on Deployment resouces.

Related to #238
@mitchnielsen mitchnielsen mentioned this issue Aug 20, 2024
Merged
mitchnielsen added a commit that referenced this issue Aug 21, 2024
@mitchnielsen @github-actions
feat(Deployments): support Parameters (#245)
b1d88a8 
* feat(Deployments): support Parameters

Supports setting Parameters on Deployment resouces.

Related to #238

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@felixpelletier felixpelletier mentioned this issue Aug 26, 2024
Merged
@jamiezieziula jamiezieziula added the Migrated label Aug 28, 2024 — with Linear
@jamiezieziula jamiezieziula removed Migrated enhancement New feature or request labels Aug 28, 2024
@felixpelletier
Copy link
Contributor

felixpelletier commented Sep 5, 2024 •
edited
Loading

If I may cast my vote: the most important params for my use case would be:

  • parameter_openapi_schema (for convenience, since the HTTP PATCH method for that particular param doesn't work in the REST API)
  • Deployment Access (by far the most important to us, but we can manage by using a local-exec provisioner on a null_resource and apply it on every terraform apply. No big deal.)
  • schedules

@mitchnielsen
Copy link
Contributor Author

Thanks @felixpelletier, this helps - I updated the description to add access to the top and moved parameter_openapi_schema and schedules up.

@mitchnielsen mitchnielsen mentioned this issue Sep 19, 2024
Merged
mitchnielsen added a commit that referenced this issue Sep 19, 2024
@mitchnielsen
feat(Deployments): support ParameterOpenAPISchema
1c4629f 
Adds support for the ParameterOpenAPISchema for the Deployment resource.

Related to #238

Related to https://linear.app/prefect/issue/PLA-185/support-for-deployments-resource
@mitchnielsen mitchnielsen mentioned this issue Sep 19, 2024
Merged
@mitchnielsen mitchnielsen changed the title Support for Deployments resource Add support for Deployments resource Sep 23, 2024
@mitchnielsen mitchnielsen changed the title Add support for Deployments resource Add support for Deployments Sep 24, 2024
mitchnielsen added a commit that referenced this issue Oct 1, 2024
@mitchnielsen @github-actions
feat(Deployments): support ParameterOpenAPISchema (#263)
5933437 
* feat(Deployments): support ParameterOpenAPISchema

Adds support for the ParameterOpenAPISchema for the Deployment resource.

Related to #238

Related to https://linear.app/prefect/issue/PLA-185/support-for-deployments-resource

* Generate Terraform Docs

* Require replacement on value change

* Update(): Remove unused parameterOpenAPISchema var

We don't update parameterOpenAPISchema because it's not supported by the
API, so we don't need to unmarshal the variable here.

* Update example with all parameters set

* Generate Terraform Docs

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@vnagaraj vnagaraj mentioned this issue Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchnielsen mitchnielsen

Labels
development open-source
Projects
None yet
Milestone
Parity with the Prefect API
Development

No branches or pull requests
3 participants
@mitchnielsen @felixpelletier @jamiezieziula