Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQueryTask #678

Merged
merged 6 commits into from
Feb 22, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wording nit
  • Loading branch information
cicdw committed Feb 21, 2019
commit 20cf8ef10d565ff16216f3b3bb9757f167e52a83
6 changes: 3 additions & 3 deletions src/prefect/tasks/google/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class BigQueryTask(Task):
Args:
- query (str, optional): a string of the query to execute
- query_params (list[tuple], optional): a list of 3-tuples specifying BigQuery query parameters
- project (str, optional): the project to initialize the BigQuery Client with; if not provided,
- project (str, optional): the project to initialize the BigQuery Client with; if not provided,
will default to the one inferred from your credentials
- location (str, optional): location of the dataset which will be queried; defaults to "US"
- dry_run_max_bytes (int, optional): if provided, the maximum number of bytes the query is allowed
Expand Down Expand Up @@ -92,7 +92,7 @@ def run(
Args:
- query (str, optional): a string of the query to execute
- query_params (list[tuple], optional): a list of 3-tuples specifying BigQuery query parameters
- project (str, optional): the project to initialize the BigQuery Client with; if not provided,
- project (str, optional): the project to initialize the BigQuery Client with; if not provided,
will default to the one inferred from your credentials
- location (str, optional): location of the dataset which will be queried; defaults to "US"
- dry_run_max_bytes (int, optional): if provided, the maximum number of bytes the query is allowed
Expand All @@ -119,7 +119,7 @@ def run(
"""
## check for any argument inconsistencies
if query is None:
raise ValueError("No query not provided.")
raise ValueError("No query provided.")
if sum([dataset_dest is None, table_dest is None]) == 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:mind blown:

raise ValueError(
"Both `dataset_dest` and `table_dest` must be provided if writing to a destination table."
Expand Down