BigQueryTask #678
Merged
BigQueryTask #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
reviewed
Feb 21, 2019
jlowin
requested changes
Feb 22, 2019
| ## check for any argument inconsistencies | ||
| if query is None: | ||
| raise ValueError("No query provided.") | ||
| if sum([dataset_dest is None, table_dest is None]) == 1: |
| def __init__( | ||
| self, | ||
| query: str = None, | ||
| query_params: List[tuple] = None, # 3-tuples |
|
@cicdw looking good. What do you think about linking to these docs in the arg docstring for |
|
@jlowin updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)What does this PR change and why is it important?
Adds a
BigQueryTaskto the task library and adds an additional google package dependency. At some point we will need to discuss the correct way to handle our packages with testing + documentation.