Add codespell config and add to pre-commit #10893
Conversation
👷 Deploy request for prefect-docs-preview pending review.Visit the deploys page to approve it
|
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
|
well -- it needs blessing (merge) or a curse (close) |
|
Hi @yarikoptic, thanks for contributing! I don't think this will pass our pre-commit check with the misspellings in https://github.com/PrefectHQ/prefect/actions/runs/6725390065/job/18279665245?pr=10893#step:5:30. You may also need to add |
serinamarie
added
status:waiting for user
and removed
status:waiting for maintainer
labels
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
fb8204d
to
d12eb8d
Compare
|
done @serinamarie -- should be all green now. But if wait is long enough, new typos would sneak in again ;) |
Running the workflows again :) Although I think it might need to be added to our Looks like there were some failures: https://github.com/PrefectHQ/prefect/actions/runs/6738265300/job/18317503147?pr=10893#step:5:30 |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w .github/ISSUE_TEMPLATE/5_maintenance_ticket.yaml .github/workflows/python-tests.yaml .github/workflows/python-tests.yaml .github/ISSUE_TEMPLATE/2_ui_bug_report.yaml",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
unfortunately that duplicates .codespellrc settings. Filed codespell-project/codespell#3196
|
ah dang, forgot to report etc. Now did codespell-project/codespell#3196 and "fixed for it" here. |
|
and added to requirements-devel.txt |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
I also was told how to test hidden folders, so added that setting and fixed 1 more typo |
This is pretty much a continuation of #10813 (comment) to ensure that no new typo sneaks in.