Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor typos #10813

Merged
merged 20 commits into from
Sep 25, 2023
Merged

fix: minor typos #10813

merged 20 commits into from
Sep 25, 2023

Conversation

mj0nez
Copy link
Contributor

@mj0nez mj0nez commented Sep 24, 2023

closes #10812

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed

@mj0nez mj0nez requested review from a team and zangell44 as code owners September 24, 2023 21:31
@netlify
Copy link

netlify bot commented Sep 24, 2023

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c05791a

@mj0nez
Copy link
Contributor Author

mj0nez commented Sep 24, 2023

Most of the fixes affect only doc-strings or comments, but a few may influence some tests. I've tried my best to reason in those cases.

While having a extensive database of common errors, codespell outputs a few false positives when invoked without additional configuration.

The following command will ignore specific files and patterns, e.g. some which are required by sqlalchemy:

codespell --ignore-regex=".*lazy=\"selectin\"|.*e import Bloc$" --ignore-words-list=aci,wqs,aks --skip="*.js,*.css"

@jakekaplan
Copy link
Contributor

jakekaplan commented Sep 25, 2023

Hi, thanks for the contribution! I'll approve assuming this passes CI. From what I can see all the changes are purely cosmetic.

Edit: It looks like you'll need to run black on at least 1 file: https://github.com/PrefectHQ/prefect/actions/runs/6292508523/job/17102639432?pr=10813

@mj0nez
Copy link
Contributor Author

mj0nez commented Sep 25, 2023

Oh, must have missed it... I have run the hooks on all files :)

@mj0nez
Copy link
Contributor Author

mj0nez commented Sep 25, 2023

Seems like another test failed - but only on Python 3.11: https://github.com/PrefectHQ/prefect/actions/runs/6292508521/job/17102650066#step:14:16100

@jakekaplan jakekaplan merged commit 271b76d into PrefectHQ:main Sep 25, 2023
39 checks passed
@mj0nez mj0nez deleted the fix-typos branch September 25, 2023 15:23
yarikoptic added a commit to yarikoptic/prefect that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos in project
2 participants