Allow passing runspace name #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
May 7, 2019
| @@ -87,7 +87,7 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider | |||
| } | |||
| } | |||
|
|
|||
| if (!config.runspaceId) { | |||
| if (!config.runspaceId && !config.runspaceName) { | |||
| config.runspaceId = await vscode.commands.executeCommand("PowerShell.PickRunspace", config.processId); | |||
There was a problem hiding this comment.
Should we change the runspace picker to allow picking by name instead of id? If not for v1.x, then perhaps for 2.x where we only support >= 5?
There was a problem hiding this comment.
It says the name in the runspace picker so I think we're good here
rkeithhill
approved these changes
May 7, 2019
rjmholt
approved these changes
May 7, 2019
|
Will merge this in once PowerShell/PowerShellEditorServices#951 is signed off on and merged in. |
TylerLeonhardt
force-pushed
the
allow-passing-runspacename
branch
from
3c398c4 to
c02b15d
Compare
TylerLeonhardt
added a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
May 21, 2019
TylerLeonhardt
added a commit
that referenced
this pull request
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
paired with PowerShell/PowerShellEditorServices#951
Folks will be able to specify a
runspaceNamein theirlaunch.json. For example:{ "type": "powershell", "request": "attach", "runspaceName":"PowerShellManager", "customPipeName":"AzureFunctionsPSWorker" }Some actually informative
launch.jsons instead ofrunspaceId: 1!PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready