Allow passing RunspaceName #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rjmholt
reviewed
May 7, 2019
| @@ -22,6 +22,8 @@ public class AttachRequestArguments | |||
|
|
|||
| public string RunspaceId { get; set; } | |||
|
|
|||
| public object RunspaceName { get; set; } | |||
There was a problem hiding this comment.
Possible to make this a string?
rjmholt
approved these changes
May 21, 2019
rkeithhill
approved these changes
May 21, 2019
spaces Co-Authored-By: Robert Holt <rjmholt@gmail.com>
TylerLeonhardt
added a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
May 21, 2019
* Allow passing runspace name * change object to string * Apply suggestions from code review spaces Co-Authored-By: Robert Holt <rjmholt@gmail.com>
TylerLeonhardt
added a commit
that referenced
this pull request
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with PowerShell/vscode-powershell#1954
Folks will be able to specify a
runspaceNamein theirlaunch.json. For example:{ "type": "powershell", "request": "attach", "runspaceName":"PowerShellManager", "customPipeName":"AzureFunctionsPSWorker" }Some actually informative
launch.jsons instead ofrunspaceId: 1!