Skip to content

WIP Update NuGet packages in 2.0.0 branch #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

WIP Update NuGet packages in 2.0.0 branch #831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0d0889e
PSReadLine integration (#672)
SeeminglyScience Aug 22, 2018
33e9fd2
Use latest PSReadLine (#745)
rjmholt Sep 13, 2018
ee92074
Migrate to netstandard2.0 and PSStandard (#741)
rjmholt Oct 2, 2018
f86edb3
[Ignore] Fix rebase errors, migrate upstream tests
Oct 2, 2018
a8f7d2d
[Ignore] Fix test typos
Oct 2, 2018
a1ac5ef
[Ignore] Use correct AppVeyor version
rjmholt Oct 8, 2018
30010f7
Set Runspaces to use STA when running in Windows PowerShell (#769)
rjmholt Oct 12, 2018
6427f9f
Update PSStandard dependency (#771)
rjmholt Oct 15, 2018
c6bd091
Removed ShowOnlineHelp Message (#775)
corbob Oct 24, 2018
22159d4
Add Async suffix to async methods (#792)
dee-see Nov 13, 2018
0aa03e2
[Ignore] no need for package sources (#803)
TylerLeonhardt Dec 1, 2018
e8323e7
allow fork build
bergmeister Dec 15, 2018
89dadb4
update nuget packages and cleanup and add 5.1 reference assemblies
bergmeister Dec 15, 2018
4111326
use psstandard everywhere
bergmeister Dec 15, 2018
6d23968
update other nuget packages
bergmeister Dec 15, 2018
93c5d34
Revert "allow fork build"
bergmeister Dec 15, 2018
bc93e55
update .net core sdk to 2.1.500
bergmeister Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed ShowOnlineHelp Message (#775)
  • Loading branch information
@corbob @rjmholt
corbob authored and rjmholt committed Oct 24, 2018
commit c6bd0917f390ee80e22db92f464e92d2995d23d0
8 changes: 0 additions & 8 deletions src/PowerShellEditorServices.Protocol/LanguageServer/ShowHelpRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@
namespace Microsoft.PowerShell.EditorServices.Protocol.LanguageServer
{

[Obsolete("This class is deprecated. Use ShowHelpRequest instead.")]
public class ShowOnlineHelpRequest
{
public static readonly
RequestType<string, object, object, object> Type =
RequestType<string, object, object, object>.Create("powerShell/showOnlineHelp");
}

public class ShowHelpRequest
{
public static readonly
Expand Down
14 changes: 0 additions & 14 deletions src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ public void Start()
DocumentRangeFormattingRequest.Type,
this.HandleDocumentRangeFormattingRequest);

this.messageHandlers.SetRequestHandler(ShowOnlineHelpRequest.Type, this.HandleShowOnlineHelpRequest);
this.messageHandlers.SetRequestHandler(ShowHelpRequest.Type, this.HandleShowHelpRequest);

this.messageHandlers.SetRequestHandler(ExpandAliasRequest.Type, this.HandleExpandAliasRequest);
Expand Down Expand Up @@ -291,19 +290,6 @@ protected async Task HandleShowHelpRequest(
await requestContext.SendResult(null);
}

protected async Task HandleShowOnlineHelpRequest(
string helpParams,
RequestContext<object> requestContext
)
{
PSCommand commandDeprecated = new PSCommand()
.AddCommand("Microsoft.PowerShell.Utility\\Write-Verbose")
.AddParameter("Message", "'powerShell/showOnlineHelp' has been deprecated. Use 'powerShell/showHelp' instead.");

await editorSession.PowerShellContext.ExecuteCommand<PSObject>(commandDeprecated, sendOutputToHost: true);
await this.HandleShowHelpRequest(helpParams, requestContext);
}

private async Task HandleSetPSSARulesRequest(
object param,
RequestContext<object> requestContext)
Expand Down