WIP Update NuGet packages in 2.0.0 branch #831

bergmeister · 2018-12-15T21:07:26Z

Use RTM version of PowerShellStandard.Library 5.1 everywhere
Update Serilog.Sinks.Async NuGet package
Update other xunit and testing packages used for testing only
Update .net core sdk to 2.1.500, which is now available in the AppVeyor image out of the box
Remove old dnx artifact from the .Net Core Preview days

Unfortunately the AppVeyor build is not working any more (the same error also happens in the unmodified 2.0.0 branch)

@bergmeister

* Add infrastructure for managing context Adds classes that manage the state of the prompt, nested contexts, and multiple ReadLine implementations of varying complexity. (cherry picked from commit 7ca8b9b) * Console related classes changes Change ReadLine method to call out to PowerShellContext. This lets the PowerShellContext determine which ReadLine implementation to use based on available modules. Also includes some changes to the System.Console proxy classes to account for PSReadLine. (cherry picked from commit 59bfa3b) * Rewrite command invocation operations for PSRL Refactor PowerShellContext to have a more robust system for tracking the context in which commands are invoked. This is a significant change in that all interactions with the runspace must be done through methods in PowerShellContext. These changes also greatly increase stability. (cherry picked from commit 21e6b5f) * Rewrite direct SessionStateProxy calls All interactions with the runspace must be done through PowerShellContext now that nested PowerShell instances are encountered frequently. Also fix a bunch of race conditions that were made more obvious with the changes. (cherry picked from commit fa2faba) * Pass feature flags to Start-EditorServicesHost * Address feedback and fix travis build error - Address feedback from @bergmeister - Fix a few other similar mistakes I found - Fix travis build failing due to missing documentation comment tag * Fix all tests except ServiceLoadsProfileOnDemand - Fix an issue where intellisense wouldn't finish if PSReadLine was not running - Fix a crash that would occur if the PSHost was not set up for input like the one used in our tests - Fix a compile error when building against PSv3/4 - Fix a hang that occurred when the PromptNest was disposed during a debug session - Fix some XML documentation comment syntax errors * Fix extra new lines outputted after each command Removed a call to WriteOutput where it wasn't required. This was creating extra new lines which failed tests (and obviously didn't look right). * Remove unused field from InvocationEventQueue And also fix spacing between the other fields. * Remove copying of PDB's in build script @rjmholt did a better job of this in a different PR that we can merge into 2.0.0 later. It also doesn't make sense in this PR. * Add AppVeyor tracking to branch 2.0.0 * Fix ambiguous method crash on CoreCLR Simplify delegate creation in PSReadLineProxy and fix the immediate ambiguous method crash the complicated code caused on CoreCLR. * first round of feedback changes * Some more feedback changes * add a bunch of copyright headers I missed * remove KeyAvailable query * Get the latest PSReadLine module installed * Add PSReadLine installation to build script * the file should be downloaded as a .zip * Address remaining feedback * Attempt to fix issue with native apps and input On Unix like platforms some native applications do not work properly if our event subscriber is active. I suspect this is due to PSReadLine querying cursor position prior to checking for events. I believe the cursor position response emitted is being read as input. I've attempted to fix this by hooking into PSHost.NotifyBeginApplication to temporarly remove the event subscriber, and PSHost.NotifyEndApplication to recreate it afterwards. * Revert "Attempt to fix issue with native apps and input" This reverts commit 1682410. * Fix build failure

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

* Move PSES builds to netstandard and use PSStandard APIs * Add shim modules for Windows PowerShell and PowerShell Core 6.0 * Migrate tests to run on .NET Core and on *nix * Make build file more declarative * Use latest xunit * Exclude host integration tests * Clean out csproj files * Fix up Travis build * Retire compatibility APIs for PowerShell v3/4 * Introduce test hook for using InitialSessionState.CreateDefault2() when running on PowerShell Core SDK * Fix session details gathering in nested prompts To create a nested PowerShell instance you can't set the runspace because the target runspace is assumed to be the runspace in TLS.

…ll#769)

This reverts commit e8323e7.

rjmholt

This looks good. Thanks @bergmeister!

rjmholt · 2018-12-17T19:58:45Z

Looks like the build is failing because of an argument in the build.ps1 file.

rkeithhill · 2018-12-17T21:46:04Z

So this is not my area of expertise. It seems that PowerShellStandard.Library replaces Microsoft.PowerShell.SDK and Microsoft.PowerShell.5.ReferenceAssemblies?

rkeithhill

LGTM with caveat that this is not my area of expertise.

rjmholt · 2018-12-17T21:54:06Z

@rkeithhill

So this is not my area of expertise. It seems that PowerShellStandard.Library replaces Microsoft.PowerShell.SDK and Microsoft.PowerShell.5.ReferenceAssemblies?

Yeah, PowerShellStandard takes the intersection of the two as a compile-time API. Meaning you can write code that targets both and the API surface is compile-checked. The whole assembly is just a shell with no implementation, but is versioned to be the same as the runtime target, so just slots in when loaded. It's not an ideal solution, but by far the simplest.

It doesn't do any translation or semantic checking though, so if APIs take and return the same types but do something different, we need to do runtime checks.

SeeminglyScience · 2018-12-18T12:59:32Z

test/PowerShellEditorServices.Test.Host/PowerShellEditorServices.Test.Host.csproj

-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
-    <PackageReference Include="xunit" Version="2.4.1-pre.build.4059" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
+    <PackageReference Include="PowerShellStandard.Library" Version="5.1.0" PrivateAssets="All" />


Is this working with Xunit now? The tests were not set up to reference PowerShell standard because Xunit runs in it's own process, not PowerShell's. So it was actually using the reference assembly. Microsoft.PowerShell.5.ReferenceAssemblies is also a reference assembly, but because it's full CLR (well, I'm guessing this is why) it properly redirects to the GAC assembly.

Not sure due to the build failure that happens in 2.0.0 (also without any changes). It might be better to use dotnet test with a test adapter instead because the dotnet xunit has been deprecated ago due to the problems that it has. I did this change in the PowerShell repo PR here, a similar change could be applied here as welll.

This won't work with PSStandard. It will call the PSStandard default API and fail. It needs to target the relevant PowerShell implementation.

Ideally we would actually load the thing as a module in a PowerShell exe and test it out that way with Pester. But that would mean moving us off xunit.

It's Xunit XOR pwsh.exe

SeeminglyScience · 2018-12-18T13:00:19Z

test/PowerShellEditorServices.Test.Protocol/PowerShellEditorServices.Test.Protocol.csproj

-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
-    <PackageReference Include="xunit" Version="2.4.1-pre.build.4059" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
+    <PackageReference Include="PowerShellStandard.Library" Version="5.1.0" PrivateAssets="All" />


echo: xunit question

SeeminglyScience · 2018-12-18T13:00:30Z

test/PowerShellEditorServices.Test/PowerShellEditorServices.Test.csproj

-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
-    <PackageReference Include="xunit" Version="2.4.1-pre.build.4059" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
+    <PackageReference Include="PowerShellStandard.Library" Version="5.1.0" PrivateAssets="All" />


echo: xunit question

bergmeister · 2019-01-21T14:42:18Z

Closing due to merge conflicts being too big due to the rebase

SeeminglyScience and others added 15 commits October 2, 2018 13:16

Use latest PSReadLine (PowerShell#745)

33e9fd2

* Use PSRL release and filter out previous betas * Use fully qualified type name for broad PowerShell support * Fix CI module installation

[Ignore] Fix rebase errors, migrate upstream tests

f86edb3

[Ignore] Fix test typos

a8f7d2d

[Ignore] Use correct AppVeyor version

a1ac5ef

Set Runspaces to use STA when running in Windows PowerShell (PowerShe…

30010f7

…ll#769)

Update PSStandard dependency (PowerShell#771)

6427f9f

Removed ShowOnlineHelp Message (PowerShell#775)

c6bd091

Add Async suffix to async methods (PowerShell#792)

22159d4

[Ignore] no need for package sources (PowerShell#803)

0aa03e2

allow fork build

e8323e7

update nuget packages and cleanup and add 5.1 reference assemblies

89dadb4

use psstandard everywhere

4111326

update other nuget packages

6d23968

bergmeister requested review from rjmholt and SeeminglyScience as code owners December 15, 2018 21:07

bergmeister added 2 commits December 15, 2018 21:08

Revert "allow fork build"

93c5d34

This reverts commit e8323e7.

update .net core sdk to 2.1.500

bc93e55

rjmholt approved these changes Dec 17, 2018

View reviewed changes

rjmholt requested review from TylerLeonhardt and rkeithhill December 17, 2018 19:44

rkeithhill approved these changes Dec 17, 2018

View reviewed changes

SeeminglyScience reviewed Dec 18, 2018

View reviewed changes

bergmeister changed the title ~~Update NuGet packages in 2.0.0 branch~~ WIP Update NuGet packages in 2.0.0 branch Dec 18, 2018

rjmholt force-pushed the 2.0.0 branch 2 times, most recently from 6e8c46b to 91f9b1a Compare January 18, 2019 20:26

bergmeister closed this Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP Update NuGet packages in 2.0.0 branch #831

WIP Update NuGet packages in 2.0.0 branch #831

Uh oh!

bergmeister commented Dec 15, 2018 •

edited

Loading

Uh oh!

rjmholt left a comment

Uh oh!

rjmholt commented Dec 17, 2018

Uh oh!

rkeithhill commented Dec 17, 2018

Uh oh!

rkeithhill left a comment

Uh oh!

rjmholt commented Dec 17, 2018

Uh oh!

SeeminglyScience Dec 18, 2018

Uh oh!

bergmeister Dec 18, 2018 •

edited

Loading

Uh oh!

rjmholt Dec 18, 2018 •

edited

Loading

Uh oh!

SeeminglyScience Dec 18, 2018

Uh oh!

SeeminglyScience Dec 18, 2018

Uh oh!

bergmeister commented Jan 21, 2019

Uh oh!

Uh oh!

WIP Update NuGet packages in 2.0.0 branch #831

WIP Update NuGet packages in 2.0.0 branch #831

Uh oh!

Conversation

bergmeister commented Dec 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjmholt left a comment

Choose a reason for hiding this comment

Uh oh!

rjmholt commented Dec 17, 2018

Uh oh!

rkeithhill commented Dec 17, 2018

Uh oh!

rkeithhill left a comment

Choose a reason for hiding this comment

Uh oh!

rjmholt commented Dec 17, 2018

Uh oh!

SeeminglyScience Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

bergmeister Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjmholt Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SeeminglyScience Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

SeeminglyScience Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

bergmeister commented Jan 21, 2019

Uh oh!

Uh oh!

bergmeister commented Dec 15, 2018 •

edited

Loading

bergmeister Dec 18, 2018 •

edited

Loading

rjmholt Dec 18, 2018 •

edited

Loading