Convert all projects to use .NET CLI preview4 tools #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It finally works! I'm really pleased with the new MSBuild-based toolset. I'll get the AppVeyor build and tests passing again today, hopefully should get far enough along that we can start using this for day to day development. Best part is that we can now use VS Code for PSES development :) |
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
18 times, most recently
from
82b737d to
497e658
Compare
|
Looks like the AppVeyor build is finally working! I've got a few more things to finish up before merging. Remaining Work
|
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
from
5731bc5 to
e67344c
Compare
This change migrates all existing projects over to MSBuild projects that work with preview4 of the dotnet cli tools. This allows us to build our Full- and CoreCLR code with a single set of projects, even our our CI server.
This change establishes an Invoke-Build script for building and testing the project, the VS Code tasks that will launch the build script, and an AppVeyor configuration that can run the build script in a CI build.
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
from
e67344c to
41ac945
Compare
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
from
9bf7364 to
cd3a1f4
Compare
daviwil
changed the title
daviwil
changed the title
12 tasks
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
2 times, most recently
from
467af68 to
c0bf13a
Compare
This change updates the .build.ps1 script to point at the 1.0.0-rc3 release of the .NET SDK so that we can make use of updated test command that returns the correct exit code when tests fail. The build script is also updated to pull the SDK version from global.json. This file is also used to tell the dotnet CLI tool which SDK version to use.
There are some issues with the rc3/rc4 releases of the SDK around NuGet packaging, constant failures. Downgrading to preview4 until those are investigated and resolved.
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
from
bd566d1 to
bd3b3f6
Compare
Apparently the default build script name for Invoke-Build is not .build.ps1, it's actually FolderName.build.ps1. That works out better for developers on Linux and macOS because the build script will not be hidden in directory listings.
See #353 for more details on why this doesn't work currently.
daviwil
force-pushed
the
daviwil/dotnet-cli-redux
branch
from
4d40650 to
bad9870
Compare
|
Everything works well with the new VS Code integration, merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates all existing projects over to MSBuild projects
that work with preview4 of the dotnet cli tools. This allows us to build
our Full- and CoreCLR code with a single set of projects, even our our CI
server.