WIP: Convert projects to project.json #282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the WSMan package dependency is also a problem on Windows, going to disable net451 build until that package gets shipped. Issue tracked here: PowerShell/PowerShell#2065 |
daviwil
force-pushed
the
daviwil/dotnet-cli
branch
6 times, most recently
from
c3dcfb4 to
6d198cd
Compare
This change converts all existing projects to the new project.json format which can build both full CLR and CoreCLR binaries for these assemblies.
This change makes some spot fixes to alleviate compiler warnings that were being produced in the Protocol project.
daviwil
force-pushed
the
daviwil/dotnet-cli
branch
2 times, most recently
from
69768cc to
e7e4f75
Compare
daviwil
force-pushed
the
daviwil/dotnet-cli
branch
from
e7e4f75 to
627d662
Compare
|
This PR isn't needed anymore now that #351 is a success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts all existing projects to the new project.json format which can build both full CLR and CoreCLR binaries for these assemblies. Tracked by issue #281.
Starting this pull request early so I can test AppVeyor build/test runs.
Things to do
NanoServercompiler directives toCoreCLRdotnet packstep to create NuGet packagesPowerShellEditorServices.psm1to load binaries from updated paths in module