Set EnableProfileLoading default to true
#1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
May 17, 2022
|
This seems to break in the end-to-end tests. Grr. |
andyleejordan
force-pushed
the
andschwa/enable-profile-loading
branch
2 times, most recently
from
13df858 to
483a3fd
Compare
So it can be turned off if needed, but otherwise has a sane default. We need to turn it off during E2E testing for CI.
andyleejordan
force-pushed
the
andschwa/enable-profile-loading
branch
from
483a3fd to
c4202e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it can be turned off if needed, but otherwise has a sane default.