Workaround test failures caused by upstream changes #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Bug
andyleejordan
force-pushed
the
andschwa/metadata-fix
branch
4 times, most recently
from
0c63862 to
2ccbbf3
Compare
andyleejordan
force-pushed
the
andschwa/metadata-fix
branch
2 times, most recently
from
a867cf8 to
78220e0
Compare
andyleejordan
force-pushed
the
andschwa/metadata-fix
branch
from
78220e0 to
d69c330
Compare
SeeminglyScience
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, um, I think what happened is that CI builds PSES from the tip of its master branch. So as soon as PowerShell/PowerShellEditorServices#1802 was merged, any CI triggered here afterwards started failing because the ADO machines have, I don't know, some weird/broken profile? This was tough to track down because at the same time, I noticed like in microsoft/vscode#148975 that our
package.jsonwas being reformatted and updated with this__metadatafield, and additionally, Code's shell integration is now on by default. I've turned that off for the tests as well (though strangely it looks like it's still trying to run in CI, but no longer failing at least).