Skip to content

Type completion with tooltips #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 9, 2020
Merged

Type completion with tooltips #1352

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4fc43f0
Should improve type completion
hc-jb-lewis Aug 21, 2020
c3ca4c0
New Class for type name completion test
hc-jb-lewis Aug 21, 2020
5135778
New test for type name completion
hc-jb-lewis Aug 21, 2020
3621114
type name completion example
hc-jb-lewis Aug 21, 2020
b780ecc
semicolons and barce mismatches
hc-jb-lewis Aug 21, 2020
c686152
Case sensitivity
hc-jb-lewis Aug 21, 2020
b4879be
methods are case sensitive, too!
hc-jb-lewis Aug 21, 2020
b50fc95
dots count!
hc-jb-lewis Aug 21, 2020
9a6e1b9
better test example
hc-jb-lewis Aug 21, 2020
481c4c1
added more characters. Test still not passing
hc-jb-lewis Aug 24, 2020
0caf978
Tyler's suggestions for the test criteria (it works for him)
hc-jb-lewis Aug 24, 2020
f47ae9d
the whole type name
TylerLeonhardt Aug 25, 2020
84b4f67
Completing Namespace completions
hc-jb-lewis Aug 25, 2020
4d1ee82
make 25 15 for namespace
TylerLeonhardt Aug 25, 2020
afa88fa
try this with the namespace test
TylerLeonhardt Sep 8, 2020
dfc4c8f
rev line number
TylerLeonhardt Sep 8, 2020
9801156
Don't use GetTypeInfo()
TylerLeonhardt Sep 8, 2020
3fd2a06
skip on windows powershell
TylerLeonhardt Sep 9, 2020
0ad0843
add skippable fact
TylerLeonhardt Sep 9, 2020
d5ac379
add versionutils
TylerLeonhardt Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add versionutils
  • Loading branch information
@TylerLeonhardt
TylerLeonhardt committed Sep 9, 2020
commit d5ac3796e29c023cbc24e3f50a8722c625af3906
7 changes: 4 additions & 3 deletions test/PowerShellEditorServices.Test/Language/LanguageServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
using Microsoft.PowerShell.EditorServices.Test.Shared.References;
using Microsoft.PowerShell.EditorServices.Test.Shared.SymbolDetails;
using Microsoft.PowerShell.EditorServices.Test.Shared.Symbols;
using Microsoft.PowerShell.EditorServices.Utility;
using Xunit;
using Xunit.Abstractions;

Expand All @@ -35,7 +36,7 @@ public class LanguageServiceTests : IDisposable
private readonly PowerShellContextService powerShellContext;
private static readonly string s_baseSharedScriptPath =
Path.Combine(
Path.GetDirectoryName(RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
Path.GetDirectoryName(VersionUtils.IsWindows
// On non-Windows platforms, CodeBase has file:// in it.
// On Windows, Location points to a temp directory.
? typeof(LanguageServiceTests).Assembly.CodeBase
Expand Down Expand Up @@ -99,7 +100,7 @@ await this.GetCompletionResults(
public async Task LanguageServiceCompletesTypeName()
{
Skip.If(
TestsFixture.IsWindowsPowerShell,
!VersionUtils.IsNetCore,
"Windows PowerShell return no results from CommandCompletion in the test harness. Since it works in PS7 and works manually when I run the extension, I'm skipping this test");

CompletionResults completionResults =
Expand All @@ -126,7 +127,7 @@ await this.GetCompletionResults(
public async Task LanguageServiceCompletesNamespace()
{
Skip.If(
TestsFixture.IsWindowsPowerShell,
!VersionUtils.IsNetCore,
"Windows PowerShell return no results from CommandCompletion in the test harness. Since it works in PS7 and works manually when I run the extension, I'm skipping this test");

CompletionResults completionResults =
Expand Down