Skip to content

Conversation

@AspenForester
Copy link
Contributor

Resolves PowerShell/vscode-powershell#2898
Adds tool tips for type completions, tests for completion are included.

@TylerLeonhardt
Copy link
Member

hmm the Windows failures are different than the Windows failures...

@TylerLeonhardt
Copy link
Member

So apparently CompletionType.Namespace is a thing... which would be System.Collections where as CompletionType.Type is System.Collections.ArrayList so you should also have a:

case CompletionType.Namespace:

@TylerLeonhardt
Copy link
Member

This test passes in PS7 but fails in Windows PowerShell

@AspenForester
Copy link
Contributor Author

Unfortunately, I don't understand why the tests fail. The two I created with @TylerLeonhardt's assistance seem to follow the model of the existing tests, but the completions results come back empty for the example provided for type completion.

@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review September 9, 2020 18:08
@TylerLeonhardt
Copy link
Member

A whole lot of nonsense for two lines of code... Thanks for putting up with the headache @AspenForester. Not sure why the tests don't work on Windows PowerShell but at least we'll have coverage for other PowerShell's and you confirmed it worked for Windows PowerShell manually...

I've opened #1355 to track the test weirdness.

@TylerLeonhardt
Copy link
Member

CI is green so I'm merging.

@TylerLeonhardt TylerLeonhardt merged commit b8ad2c7 into PowerShell:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full type name when using ctrl+space

4 participants