Skip to content

Fix the source location of PowerShell.Core.Instrumentation.dll #7226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 3, 2018

PR Summary

Fix the source location of PowerShell.Core.Instrumentation.dll. When building with VS 2017, the resource binary is placed in the current folder.

PR Checklist

@daxian-dbw
Copy link
Member Author

@adityapatwardhan I submitted the same changes to powershell-native repo: PowerShell/PowerShell-Native#3

@daxian-dbw daxian-dbw merged commit 73d71d9 into PowerShell:master Jul 4, 2018
@daxian-dbw daxian-dbw deleted the build branch July 4, 2018 01:06
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 6, 2018

I wonder why we fix here if we use nuget package. I suggest cut off, use https://github.com/PowerShell/PowerShell-Native and remove the code here.

@daxian-dbw
Copy link
Member Author

@iSazonov Active development still depends on building native components, for example, I run into this when working on the experimental feature. So it's better to keep parity until we know the powershell-native repo is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants