Location of build artifacts for native Windows binaries

[PetSerAl]

Recently tried to compile PowerShell native Windows binaries and this last copy operation:

PowerShell/build.psm1

Lines 307 to 311 in d04fef4

	# Copy the binary to the packaging directory
	# NOTE: No PDB file; it's a resource-only DLL.
	# VS2017 puts this in $HOME\source
	$srcPath = [IO.Path]::Combine($HOME, "source", $Configuration, 'PowerShell.Core.Instrumentation.dll')
	Copy-Item -Path $srcPath -Destination $dstPath

of Start-BuildNativeWindowsBinaries failed due to absence of file in expected location.

For me file (result of compilation) was located in \src\PowerShell.Core.Instrumentation relative to repo root, but not in $HOME\source as stated in the comment. Is that error here or location was changed or is dependent of environment? Should build script be fixed or enhanced to cover other location of build artifacts?

[bergmeister]

I can confirm the same happens on my machine (latest VS 15.7.4 on Win 10 1803). I have to say though that I have never used this function before as I never needed it.
I should add that when I first ran it, I had problems due to missing atlbase.h headers, which I could fix by installing the optional Visual Studio component Visual C++ ATL support

[iSazonov]

We should clean up the script - native binaries was moved to https://github.com/PowerShell/PowerShell-native.

[PetSerAl]

It seem the other repo have this exact lines commented out and use different logic to locate build artifacts.

[daxian-dbw]

I also ran into this issue. I submitted PRs to fix it both in powershell repo (#7226) and the powershell-native repo (PowerShell/PowerShell-Native#3).