Skip to content

Fix syntax error in Windows packaging script #14377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Dec 10, 2020

PR Summary

Fixes a parse error in the Windows packaging automation caused by #14090.

PR Context

PR Checklist

@rjmholt rjmholt assigned TravisEz13 and rjmholt and unassigned iSazonov and TravisEz13 Dec 10, 2020
@rjmholt
Copy link
Collaborator Author

rjmholt commented Dec 10, 2020

@PoshChan please remind me 2 hours

@PoshChan
Copy link
Collaborator

@rjmholt, I do not understand: please remind me 2 hours

Commands available in this repo for you:
  • retry <target> this will attempt to retry only the failed jobs for the target pipeline, restart can be used in place of retry
  • rebuild <target> this will perform a complete rebuild of the target pipeline, rerun can be used in place of rebuild Supported values for <target> which can be a comma separated list are: static,windows,macos,linux,ssh,all
  • get failures this will attempt to get the latest failures for all of the target pipelines
  • remind me in <value> <units> this will create a reminder that will be posted after the specified duration <value> is a number, and <units> can be minutes, hours, or days (singular or plural)

@rjmholt
Copy link
Collaborator Author

rjmholt commented Dec 10, 2020

@PoshChan please remind me in 2 hours

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned rjmholt Dec 10, 2020
@TravisEz13 TravisEz13 merged commit 9d50a05 into PowerShell:master Dec 10, 2020
@rjmholt rjmholt deleted the fix-windows-pkging branch December 10, 2020 21:46
@PoshChan
Copy link
Collaborator

@rjmholt, this is the reminder you requested 2 hours ago

@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 11, 2020
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit that referenced this pull request Dec 16, 2020
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@TravisEz13 TravisEz13 added BackPort-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Dec 16, 2020
TravisEz13 pushed a commit that referenced this pull request Dec 16, 2020
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
rjmholt added a commit to rjmholt/PowerShell that referenced this pull request Jan 12, 2021
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@ghost
Copy link

ghost commented Jan 14, 2021

🎉v7.1.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 19, 2021

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants