Use Microsoft.PowerShell.MarkdownRender package from nuget.org

[adityapatwardhan]

PR Summary

The code for Microsoft.PowerShell.MarkdownRender has been moved to a separate repository https://github.com/powershell/markdownrender. This PR removes the code from this repository and uses the package from nuget.org instead

PR Context

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[xtqqczze]

I see the initial commit PowerShell/MarkdownRender@345e2f3 was on 2020-10-02. We should ensure changes made in the last few months are reflected in powershell/markdownrender:

• Fix IDE0044: MakeFieldReadonly part 7 #13890
• Remove unnecessary usings part 7 #14066
• Use read-only auto-implemented properties #13507
• Enable IDE0075: SimplifyConditionalExpression #14078

[TravisEz13]

This file should be signed in your build, so can you remove it from our signing?

[adityapatwardhan]

@TravisEz13 - please re-review

[adityapatwardhan]

@rjmholt This is ready for review now.

[adityapatwardhan]

@xtqqczze - Filed issue in MarkdownRender repo to make sure the improvements mentioned above are taken there: PowerShell/MarkdownRender#11

[adityapatwardhan]

@rjmholt This is ready to merge.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[xtqqczze]

@iSazonov We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

[iSazonov]

@iSazonov We should avoid merging any more changes to Microsoft.PowerShell.MarkdownRender, like those in #14078.

These files will simply be deleted - this does not affect anything.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[rjmholt]

@PoshChan please remind me in 1 hour

[PoshChan]

@rjmholt, this is the reminder you requested 1 hour ago

[ghost]

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes