Skip to content

Fix parameter dynamic help when the help content is specified in ParameterAttribute #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix parameter dynamic help when the help content is specified in ParameterAttribute #3370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions PSReadLine/DynamicHelp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,12 @@ private void WriteParameterHelp(dynamic helpContent)
{
Collection<string> helpBlock;

if (string.IsNullOrEmpty(helpContent?.Description?[0]?.Text))
if (helpContent?.Description is not string descriptionText)
{
descriptionText = helpContent?.Description?[0]?.Text;
}

if (descriptionText is null)
{
helpBlock = new Collection<string>()
{
Expand All @@ -216,7 +221,7 @@ private void WriteParameterHelp(dynamic helpContent)
string.Empty
};

string text = helpContent.Description[0].Text;
string text = descriptionText;
if (text.Contains("\n"))
{
string[] lines = text.Split(new char[] { '\n' }, StringSplitOptions.RemoveEmptyEntries);
Expand Down