Skip to content

Fix parameter dynamic help when the help content is specified in ParameterAttribute #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix parameter dynamic help when the help content is specified in ParameterAttribute #3370

merged 1 commit into from
Jul 5, 2022

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 5, 2022 •
edited
Loading

PR Summary

Fix #3367
Fix parameter dynamic help when the help content is specified in ParameterAttribute.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

andyleejordan
andyleejordan approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw daxian-dbw merged commit 36893ee into PowerShell:master Jul 5, 2022
@daxian-dbw daxian-dbw deleted the help branch July 5, 2022 23:11
@daxian-dbw daxian-dbw mentioned this pull request Jul 5, 2022
Closed
3 tasks
@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ALT+H causes exception with parameter help message

2 participants

@daxian-dbw @andyleejordan